feat: make man pages be included in wheels too!

[vergenzt]

1235 only managed to get them included in sdists 🙈

Resolves #1234 for real now

I tested and confirmed now that both sdists and wheels end up with the files!

[jpmckinney]

Reading the Stackoverflow message, does MANIFEST.in need to be updated, or no?

[harkabeeparolus]

Reading the Stackoverflow message, does MANIFEST.in need to be updated, or no?

No, MANIFEST.in rules are not needed for something explicitly specified with data_files:

[...] More precisely, the following files are included in a source distribution by default: [...]

• All files specified by the package-data and data-files configuration parameters in pyproject.toml and/or equivalent in setup.cfg/setup.py;

[Source: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html]

[harkabeeparolus]

By the way, is there anything I could do to help get this PR past the finish line? I use csvkit daily, and I'm also a Python dev.

[jpmckinney]

Aha, wheel ignores include_package_data and MANIFEST.in.

[coveralls]

coverage: 90.381% (-0.01%) from 90.393% when pulling 9209deacde8ea2266681b88f3d68991e6b8a2823 on vergenzt:gh-1234-include-manpages-in-wheels into f73742fc0ec4c993b5f76809ee15dfab8a0cef10 on wireservice:master.

[coveralls]

coverage: 90.381% (-0.01%) from 90.393% when pulling 9209deacde8ea2266681b88f3d68991e6b8a2823 on vergenzt:gh-1234-include-manpages-in-wheels into f73742fc0ec4c993b5f76809ee15dfab8a0cef10 on wireservice:master.

[harkabeeparolus]

Thanks! 🤩 🙏

[vergenzt]

Thanks so much you two!!