search

wireui / wireui

TallStack UI components
https://v1.wireui.dev
MIT License
1.37k stars 166 forks source link

Buttons no longer rendering class content #767

Closed titonova closed 6 months ago

titonova commented 6 months ago

In the commit committed about 50 minutes ago (for v1.18.5 Latest), it causes a bug such that buttons no longer render appropriately.

Doing:

<x-button primary label="Button"/> now returns 

<button wire:loading.attr="disabled" wire:loading.class="!cursor-wait" type="button" primary="primary">
    <!--[if BLOCK]><![endif]--> <!--[if ENDBLOCK]><![endif]-->

    Button

    <!--[if BLOCK]><![endif]--> <!--[if ENDBLOCK]><![endif]-->

    <!--[if BLOCK]><![endif]--> <!--[if ENDBLOCK]><![endif]-->
</button>

As you can see, rather than it giving it the appropriate classes that correspond to the primary attribute, it simply renders the attribute as primary="primary".

It's most likely something related to:

image

PH7-Jack commented 6 months ago

Thanks for reporting, it is fixed now Check https://github.com/wireui/wireui/releases/tag/v1.18.6

titonova commented 6 months ago

Thanks 🙏🏾.

Lol committed, pushed, bug reported, bug fixed, re-pushed, all in 1 hour