search

wireviz / WireViz

Easily document cables and wiring harnesses.
GNU General Public License v3.0
4.33k stars 223 forks source link

Rename placehoder "sheetsize_default" to <!-- %template_sheetsize% --> #380

Closed kvid closed 3 months ago

kvid commented 3 months ago

@formatc1702 must must check if this suggested change (placeholder name consistency) is OK, or if it might have some bad side-effects. If there is a good reason to keep this one placeholder very different from the others, then that reason should be explained in a code comment.

A bonus advantage by using the name <!-- %template_sheetsize% -->, is that it will be easy to later generalize by letting any string or numeric metadata.{item}.{key} entry replace the corresponding <!-- %{item}_{key}% --> placeholder.

~TODO: If both PR #371 and this PR is accepted, then the templates/README.md file must be updated.~ (it is now updated)

Fixes #377

formatc1702 commented 3 months ago

Please consider my comment on the original issue, but generally I am all in favor of making placeholder syntax consistent and therefore, of amending the Readme (please do) and merging this PR.

formatc1702 commented 3 months ago

I see some recent force-pushes so I will wait for a final review request before merging :)