Closed usantos-at-wiris closed 5 months ago
To make sure the applied changes really have effect, we´d have to
await
all the methods we appended theasync
keyword to... In other words, for example, now that we madeinsertFormula
anasync
method, we need to check all places where that method is used and await its execution... This could bring us to an infinity spiral of async/await methods, let's check it at least!
The code is thought to run in serial mode, so it may not be an issue to add the async/await where needed. However, take into consideration that there are cyclic methods.
Sorry for the length of this PR. Fixed a bunch of typos and added a more considerate way to track the closing telemetry.
Changes
feat: update telemeter tracking to utilize promises. #KB-45700
Description
This PR introduces a significant enhancement to our telemeter tracking functionality by transitioning all tracking actions to utilize promises. The motivation behind this change stems from a recent integration issue encountered with OnlyOffice.
Steps to Reproduce:
wiris/telemeter
repo.cargo run
and ensure it's operational.packages/devkit/src/Integrationmodel
on this branch.debug: false
todebug: true
.yarn && nx build generic && nx start html-generic
to build the generic editor.Commands to test generic telemetry
WirisPlugin.GenericIntegration.telemeter.wrsOpenedEditorModal('button','chemistry')
WirisPlugin.GenericIntegration.telemeter.wrsClosedEditorModal('mtct_close','chemistry')
WirisPlugin.GenericIntegration.telemeter.wrsInsertedFormula('«math xmlns=¨http://www.w3.org/1998/Math/MathML¨»«msqrt»«mi»x«/mi»«/msqrt»«/math»','«math xmlns=¨http://www.w3.org/1998/Math/MathML¨»«msqrt»«mi»x«/mi»«/msqrt»«/math»',Date.now(),'chemistry')
Link to Task: #45700