Fix/use strict - Githubissues

wiris / html-integrations

The official JavaScript library for MathType, the leading formula editor and equation writer for the web by Wiris

https://wiris.com/solutions/integrations/html-editors/

MIT License

76 stars 53 forks source link

Fix/use strict #964

Closed psala-at-wiris closed 3 months ago

psala-at-wiris commented 4 months ago

Description

Add strict: true to the tsconfig.json file in the viewer package to enforce stricter typing. This will lead to more robust code and help catch potential bugs at compile time.

Steps to reproduce

Dev deployment

Check the dev deploy here, it should show the demo viewer and work as expected.

Locally

run: nx build viewer && nx start html-viewer, the code should compile and work as expected

Warning

Setting strict to true has revealed a number of errors. Resolving some of these is innocuous, but addressing others involves assumptions that are not clear about what the code should do in certain cases.

#taskid X (Waiting for the card to be created)

psala-at-wiris commented 3 months ago

Given the fact that the branch was originally created from main, there are many conflicts with the modified files, and the staging demo breaks when trying to render new formulas. This last point may be solved if the code aligns with the current master.

Given the scope and size of the PR I've created a new one from master branch to avoid conflict related issues . We should close this and review the other one.