Add strict to ts-config - Githubissues

wiris / html-integrations

The official JavaScript library for MathType, the leading formula editor and equation writer for the web by Wiris

https://wiris.com/solutions/integrations/html-editors/

MIT License

76 stars 53 forks source link

Add strict to ts-config #969

Closed psala-at-wiris closed 3 months ago

psala-at-wiris commented 3 months ago

Description

Add strict: true to the tsconfig.json file in the viewer package to enforce stricter typing. This will lead to more robust code and help catch potential bugs at compile time.

Steps to reproduce

Dev deployment

Check the dev deploy here, it should show the demo viewer and work as expected.

Locally

run: nx build viewer && nx start html-viewer, the code should compile and work as expected

Warning

Setting strict to true has revealed a number of errors. Resolving some of these is innocuous, but addressing others involves assumptions that are not clear about what the code should do in certain cases.

psala-at-wiris commented 3 months ago

It seems I can't build Generic, Tiny5 and tiny6 editors. Could you please take a look ?

I've been able to build and start tiny5, tiny6 and generic with no problems in this branch. The code only affects the viewer package, it should not break any other build except those having a dependency with the viewer. We can see this in the dependency graph provided by NX (nx dep-graph):

Screenshot from 2024-05-21 09-46-40