wiris / moodle-filter_wiris

Moodle plugin that converts any MathML or LaTeX to accessible images using the MathType API services by Wiris
https://www.wiris.com/moodle
GNU General Public License v3.0
16 stars 17 forks source link

And I press "Toggle" Behat Step failing in Tiny_wiris #143

Closed TheBryanOpen228 closed 1 month ago

TheBryanOpen228 commented 4 months ago

While adding Tiny_wiris i found a problem with the Behat automated tests from lib/editor/tiny/plugins/wiris/tests/behat Specially in the step And I press "Toggle" in "FIELDNAME" field in TinyMCE 6 editor

For example in edit_formula.feature, see:

Scenario: Create a formulas                                               # /builds/moodle/lib/editor/tiny/plugins/wiris/tests/behat/edit_formula.feature:17
And I press "Toggle" in "General description" field in TinyMCE 6 editor  # /builds/moodle/lib/editor/tiny/plugins/wiris/tests/behat/edit_formula.feature:24
"Toggle" button not found in "General description" field

This caused by a string change here in filter_wiris, see fix: Test for Moodle 4.4 compatibility The string changed from "More..." to "Reveal or hide additional toolbar items", but i don't see it added in any language File, so the Toggle button it's actually showing "More..." text.

So changing "Reveal or hide additional toolbar items" back to "More..." fix the issue, here in behat_wiris_page.php "Toggle" => "More..."

Can you fix those Behat steps? Thanks in advice

carla-at-wiris commented 4 months ago

Hello @TheBryanOpen228,

Moodle changed the title assigned to the Toggle button on their latest version 4.4, so we had to change our tests to be compatible with it. We realized that for prior versions there would be incompatibilities, so we tried to fix it on this Pull request. It is still on review since we are making big changes on our tests suites.

We will investigate the behavior of our tests when different languages are set on the Moodle instance. However, knowing the Moodle version you are using will also help us a lot!

We will let you know once we release the previous mentioned changes and any new regarding the matter.

TheBryanOpen228 commented 4 months ago

Hello, Thanks for the information. We are using 8.7.0 (2024042300) version for tiny_wiris and filter_wiris. Also, we use Moodle 4.3.4 (Build: 20240422)

So if that's the case, it explains why in 4.3 i see the error, since this change is for 4.4 Moodle Version. I will wait then for the integration of this Pull request, thank you!!

usantos-at-wiris commented 1 month ago

We just released a new moodle version 8.7.1 fixing this issue. Thanks a lot for reporting it !