search

wiscostret / fplscrapR

This package enables those interested in Fantasy Premier League to perform detailed data analysis of the game, using the FPL's JSON API. The fplscrapR functions help R users collect and parse data from the Official Fantasy Premier League website.
Creative Commons Zero v1.0 Universal
77 stars 16 forks source link

Allow multiple IDs #16

Closed eivindhammers closed 4 years ago

eivindhammers commented 4 years ago

Allow for multiple entry IDs, as is implied by the description of "entryid" in docs ("The entry ID(s)."). Also removed the line requesting round info, which doesn't seem to be used.

eivindhammers commented 4 years ago

I also added a function to retrieve captains (for multiple entries/GWs). Feel free to drop that from the pull request if it is of limited interest.

eivindhammers commented 4 years ago

Thanks for your feedback. The captains function is now in its own pull request, with suggested changes.

I second the idea of a get_entry_player_picks() function, returning a dataframe. The nested list returned by my function is something of a mess, yes.

eivindhammers commented 4 years ago

I guess this PR can be closed. I might open a new one with a get_entry_player_picks() function.

eivindhammers commented 4 years ago

Closing this PR, see #17 and #18.