Add unit tests for org.holer.common.util.HolerConfig

wisdom-projects / holer

Holer exposes local servers behind NATs and firewalls to the public internet over secure tunnels.

Apache License 2.0

2.04k stars 507 forks source link

Add unit tests for org.holer.common.util.HolerConfig #11

Closed EricHetti closed 5 years ago

EricHetti commented 5 years ago

I've analysed your codebase and noticed that org.holer.common.util.HolerConfig is not fully tested. I've written some tests for the methods in this class with the help of Diffblue Cover.

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.

EricHetti commented 5 years ago

Hi @Dom-Wang just following up and wondering if you would like me to make any changes to the PR?