search

wise-foundation / lending-audit

5 stars 4 forks source link

[OMR-01S] Inexistent Event Emissions #121

Open vm06007 opened 11 months ago

vm06007 commented 11 months ago

OMR-01S: Inexistent Event Emissions

Type Severity Location
Language Specific OwnableMaster.sol:L50, L63, L74, L85-L86

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

function proposeOwner(
    address _proposedOwner
)
    external
    onlyMaster
{
    proposedMaster = _proposedOwner;
}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

vm06007 commented 11 months ago

Resolved in: https://github.com/wise-foundation/lending-audit/pull/120