search

wise-foundation / lending-audit

5 stars 4 forks source link

[WOH-01S] Data Location Optimizations #132

Open vm06007 opened 1 year ago

vm06007 commented 1 year ago

WOH-01S: Data Location Optimizations

Type Severity Location
Gas Optimization WiseOracleHub.sol:L178-L180

Description:

The linked input arguments are set as memory in external function(s).

Example:

function addOracleBulk(
    address[] memory _tokenAddresses,
    IPriceFeed[] memory _priceFeedAddresses,
    address[][] memory _underlyingFeedTokens
)
    external
    onlyMaster
{

Recommendation:

We advise them to be set as calldata optimizing their read-access gas cost.

vm06007 commented 1 year ago

Resolved in: https://github.com/wise-foundation/lending-audit/pull/131