search

wise-foundation / lending-audit

5 stars 4 forks source link

[FMR-01S] Data Location Optimizations #133

Open vm06007 opened 1 year ago

vm06007 commented 1 year ago

FMR-01S: Data Location Optimizations

Type Severity Location
Gas Optimization FeeManager.sol:L364, L390

Description:

The linked input arguments are set as memory in external function(s).

Example:

function setBeneficial(
    address _user,
    address[] memory _feeTokens
)
    external

Recommendation:

We advise them to be set as calldata optimizing their read-access gas cost.

vm06007 commented 1 year ago

Resolved in: https://github.com/wise-foundation/lending-audit/issues/132