wise-foundation / lending-audit

5 stars 4 forks source link

[DSN-02S] Inexistent Visibility Specifiers #136

Open vm06007 opened 1 year ago

vm06007 commented 1 year ago

DSN-02S: Inexistent Visibility Specifiers

Type Severity Location
Code Style Declarations.sol:L43, L44, L47, L48

Description:

The linked variables have no visibility specifier explicitly set.

Example:

uint256 constant PRECISION_FACTOR_E18 = 1E18;

Recommendation:

We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma versions.

vm06007 commented 1 year ago

https://github.com/wise-foundation/lending-audit/pull/134