search

wise-foundation / lending-audit

5 stars 4 forks source link

[WSD-01C] Repetitive Value Literal #83

Open vm06007 opened 11 months ago

vm06007 commented 11 months ago

WSD-01C: Repetitive Value Literal

Type Severity Location
Code Style WiseSecurityDeclarations.sol:L85, L86

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

maxFeeUSD = 50000 * PRECISION_FACTOR_E18;

Recommendation:

We advise it to be set to a constant variable instead optimizing the legibility of the codebase.

vm06007 commented 11 months ago

Team would like to have ability to change this value, so it is not considered to be constant, it can be considered permament once master role is revoked by OwnableMaster contract call.

vm06007 commented 11 months ago

Ability to change this value is done through setLiquidationSettings() call