wise-foundation / lending-audit

5 stars 4 forks source link

[PNF-03C] Unclear Order of Operations #89

Open vm06007 opened 1 year ago

vm06007 commented 1 year ago

PNF-03C: Unclear Order of Operations

Type Severity Location
Code Style PositionNFTs.sol:L338

Description:

The referenced order of operations, while correct, are not immediately clear to readers.

Example:

48 + j % 10

Recommendation:

We advise the j % 10 statement which takes precedence over the addition to be wrapped in parenthesis (()), explicitly denoting that it is meant to be executed first.

vm06007 commented 1 year ago

Resolved in: https://github.com/wise-foundation/lending-audit/pull/86