Unable to close verification code modal when editing a group

wise-old-man / wise-old-man

The Open Source Old School Runescape progress tracker.

https://wiseoldman.net/

MIT License

257 stars 94 forks source link

Unable to close verification code modal when editing a group #1498

Closed Jonxslays closed 2 months ago

Jonxslays commented 6 months ago

Reproduced with Chrome and Firefox on Linux desktop.

Repro steps

Navigate to any group page
Click the 3 dots next to Update all
Click Edit

Expected results

I can hit esc or click an X in the top right of the modal to close it.

Actual results

The only way to get rid of the modal is to navigate away from the page.

psikoi commented 6 months ago

that's not really a bug, although my approach might be flawed.

The idea is that you cannot just dismiss that dialog and continue editing because the verification code is required. Maybe we should add a "Go back" option to the dialog, in case people want to go back to the group's page.

Jonxslays commented 6 months ago

Yeah, it just felt counterintuitive. I think that would be a good solution.

psikoi commented 2 months ago

Fixed in https://github.com/wise-old-man/wise-old-man/pull/1506