search

wise-old-man / wiseoldman-runelite-plugin

The RuneLite plugin for the Wise Old Man project.
BSD 2-Clause "Simplified" License
3 stars 7 forks source link

Fetching competitions fail if the player isn't tracked yet #48

Open rorro opened 5 months ago

rorro commented 5 months ago

When a player hasn't been tracked on wise old man yet, logging in with the plugin enabled will cause [WOM] Error: Player not found error message in the chatbox. This is problematic because the plugin fetches the competitions on world hopping as well which makes this error message a little spammy. This means that every new player/character will see this error message until they are high enough level to appear on the hiscores to be able to be tracked. rYUvaSg

This is possibly where a fix can be applied: https://github.com/wise-old-man/wiseoldman-runelite-plugin/blob/0c577998111d3113432a75aace9e1b33dc891fa5/src/main/java/net/wiseoldman/web/WomClient.java#L272

psikoi commented 5 months ago

Players can still be tracked even if not on the hiscores, but they won't have any stats

So that error message is probably only be shown until their first ever update

rorro commented 5 months ago

Oh true. I guess the issue still stands albeit a little less severe than I initially thought.