Voting Power rule should only accept values between 0-100 (with max 2 decimal places)

noisy commented 5 years ago

The problem:

it is possible to setup a rule with a value of Voting Power outside of range [0:100]

I did:

selection_999 681

I expected to see:

A form should not allow me to type value greater than 100

Links to steemd / steemit : https://steemd.com/tx/6407e176e75bf1562353af27f85bf6f767de6470

This task is in proggress, this is a TODO:

[x] - update Validator in steem-wise-core
[x] - release steem-wise-core
[ ] - update steem-wise-core in wise-hub and steem-wise-voter-page
[ ] - update UI in wise-hub (apply range, and decimal format)
[ ] - update UI in steem-wise-voter-page (apply decimal format)

noisy commented 5 years ago

Another strange issue:

value 1.1111%: selection_999 682

is translated into 111: "["v2:set_rules",{"voter":"wise-test1","rulesets":[["Vote if I have 1.1111% of voting power",[{"rule":"voting_power","mode":"more_than","value":111}]]]}]"

https://steemd.com/tx/b931c1ebc4169caa40ecbe9ab4587930c72bce9b

Jblew commented 5 years ago

This task is due. TODO list was placed at the top, to enable proggress monitoring in board

Jblew commented 5 years ago

@noisy

Another strange issue:

value 1.1111%: [...] is translated into 111: [...]

It is correct. In steem 111/10000 = 1,11% (two-digit precision)

wise-team / wise-hub