Ext shortcuts: Multiple issues with Find&Replace dialog

wise0704 / FlashDevelop

FlashDevelop is a free and open source code editor.

1 stars 0 forks source link

Ext shortcuts: Multiple issues with Find&Replace dialog #6

Open gene-pavlovsky opened 7 years ago

gene-pavlovsky commented 7 years ago

[x] Default keyboard shortcuts don't work
- Alt-N to find next - statusbar says "Alt+N was pressed. Waiting for a second key"
- Alt-A to find all - ...
- Alt-P to find previous - opens the Project menu!
[ ] An issue: 1) Copy some text in the code editor 2) Press Ctrl-H to bring up Find&Replace dialog 3) Press Ctrl-V to paste the text. Even though the Find&Replace dialog's text input has focus (you can type in there), the clipboard contents are pasted into the code editor.

wise0704 commented 7 years ago

Issue 1 - Mnemonics are evil. It's probably better to not allow Alt+key combinations as a first part of an extended shortcut to avoid all mnemonic issues. But there should be a better solution.

Issue 2 - ~~Related to #2~~ turns out nope

gene-pavlovsky commented 7 years ago

What do you mean by "mnemonics are evil"? Why?

wise0704 commented 7 years ago

Because it's not handled in the keydown sequence,but rather in the char input sequence, and it's been giving me a whole lot of trouble while working on extended shortcuts.

But I think I found a more efficient way to handle mnemonics. Needs more .NET source code digging to be sure though.

gene-pavlovsky commented 7 years ago

Ah, I see what you mean. Good luck :)

wise0704 commented 7 years ago

First issue fixed with 8733dd80217da0216eb68c6679d5364c612fd43a