refactor 'account' tests

wisespace-io / binance-rs

Rust Library for the Binance API

Other

636 stars 287 forks source link

refactor 'account' tests #182

Open danieleades opened 1 year ago

danieleades commented 1 year ago

this PR is derived from #180 , but i think it makes sense as an incremental improvement.

this PR

deduplicates the setup logic in the 'account' tests
modifiers the mock query matchers to no longer depend on the ordering of the query parameters

The second one is the most important, since this was adding an unnecessary constraint on the implementation (and forcing you to use BTreeMaps despite not actually needing a sorted heap).

danieleades commented 1 year ago

my intention is to roll this out to the other tests as well

danieleades commented 1 year ago

i'll mark this a draft for now. I want to see how well this generalises to the other tests before committing to the approach