search

wisespace-io / binance-rs

Rust Library for the Binance API
Other
636 stars 287 forks source link

add more endpoints: /fapi/v1/allOrders, /fapi/v1/userTrades, /sapi/v1/futures/transfer #189

Closed Y0h4n3s closed 1 year ago

wisespace-io commented 1 year ago

@Y0h4n3s could you fix the conflicts?

Y0h4n3s commented 1 year ago

@Y0h4n3s could you fix the conflicts?

fixed

Y0h4n3s commented 1 year ago

fixed the errors you can merge

wisespace-io commented 1 year ago

@Y0h4n3s almost, it still breaks due a lint error. Run cargo clippy, the error below:

error: use of `ok_or` followed by a function call
   --> src/model.rs:971:10
    |
971 |         .ok_or(ErrorKind::KlineValueMissingError(index, name))?
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::KlineValueMissingError(index, name))`
Y0h4n3s commented 1 year ago

@Y0h4n3s almost, it still breaks due a lint error. Run cargo clippy, the error below:

error: use of `ok_or` followed by a function call
   --> src/model.rs:971:10
    |
971 |         .ok_or(ErrorKind::KlineValueMissingError(index, name))?
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::KlineValueMissingError(index, name))`

how about now?