wisespace-io / binance-rs

Rust Library for the Binance API
Other
682 stars 302 forks source link

Support for /api/v3/order/test endpoint #31

Closed agodnic closed 5 years ago

agodnic commented 5 years ago

Hi!

Are you interested in supporting the Test new order endpoint?

From an interface point of view, two options come to my mind:

  1. Adding a test version for each existing function related to new orders. Example: now we have Account::limit_buy, Account::limit_sell, etc. and we could add Account::test_limit_buy, Account::test_limit_sell, etc.
  2. Adding a boolean parameter to the existing functions to indicate whether to use the test endpoint or not.

I could help with a pull request.

wisespace-io commented 5 years ago

@unterkontrolle Yes, I think it would be a nice addition to the library. I would prefer first option. Feel free to submit a PR, it is welcome.

agodnic commented 5 years ago

I'll have it ready by the end of this week.