Closed TimvanScherpenzeel closed 4 years ago
Due to ring being quite a large dependency (5.28 MB) and it is only being used once (for signing the request) I thought it would be a good idea to replace it with a simpler implementation.
ring
5.28 MB
I've based the changes on the implementation found in: https://github.com/nash-io/openlimits/blob/f10f0790d09ee20a5a36cf1e84ecb7e264848c75/binance/src/transport.rs#L220-L239
This MR also fixes a typo custon_headers -> custom_headers.
custon_headers
custom_headers
Kind regards,
Tim
@TimvanScherpenzeel Indeed. sha2 crate is actively maintained, so it is a good choice.
Due to
ring
being quite a large dependency (5.28 MB
) and it is only being used once (for signing the request) I thought it would be a good idea to replace it with a simpler implementation.I've based the changes on the implementation found in: https://github.com/nash-io/openlimits/blob/f10f0790d09ee20a5a36cf1e84ecb7e264848c75/binance/src/transport.rs#L220-L239
This MR also fixes a typo
custon_headers
->custom_headers
.Kind regards,
Tim