Add Stop Limit - Githubissues

wisespace-io / binance-rs

Rust Library for the Binance API

Other

649 stars 295 forks source link

Add Stop Limit #83

Closed ppamorim closed 3 years ago

ppamorim commented 3 years ago

In this PR I am including these functions:

stop_limit_sell_order
test_stop_limit_sell_order
stop_limit_buy_order
test_stop_limit_buy_order

It also include more concise types like:
OrderType
- Limit
- Market
- StopLossLimit
OrderSide
- Buy
- Sell

@dorak88783 Could you please review?

wisespace-io commented 3 years ago

@ppamorim, "Stop Limit" has been missing for a long time. @dorak88783 thank you for reviewing

dorak88783 commented 3 years ago

Hmm, merging this PR broke some things (https://travis-ci.org/github/wisespace-io/binance-rs/builds), I think something went wrong with separating out the other PRs.

(I never used Travis CI; I find it strange that it's possible to merge a PR that has a failing build - I'm used to either Github Actions or bitbucket/Jenkins combo, where it's configured to make it impossible to merge something with build failures).