wisespace-io / binance-rs

Rust Library for the Binance API
Other
649 stars 295 forks source link

Fix MinNotional filter. #92

Closed sergshabal closed 3 years ago

sergshabal commented 3 years ago

For Futures https://fapi.binance.com/fapi/v1/exchangeInfo response is {"filterType":"MIN_NOTIONAL","notional":"5"}

For Spot https://api.binance.com/api/v1/exchangeInfo response is {"filterType":"MIN_NOTIONAL","minNotional":"0.00010000","applyToMarket":true,"avgPriceMins":5}

dorak88783 commented 3 years ago

Well spotted!

I (very recently) made a test (https://github.com/wisespace-io/binance-rs/pull/91) on exchangeInfo, but only for spot, not for futures. Such a test would have spotted this. I never work with the future api; if you really care about it, you could add a testcase for the future API.