wisespace-io / binance-rs

Rust Library for the Binance API
Other
671 stars 300 forks source link

Futures websocket API #95

Closed ppamorim closed 3 years ago

ppamorim commented 3 years ago

[DO NOT MERGE]

Hi,

In this PR we will add the websocket client for the futures API. @wisespace-io Could you please verify or list me what structs are required for this new API? I don't understand their API documentation well compared to the current API in the spot websocket API.

This PR is still under development.

wisespace-io commented 3 years ago

@lasys In which events are you interested to subscribe? @ppamorim is working on Futures Websockets support

dorak88783 commented 3 years ago

@ppamorim do you still want to finish this? I could start to look into it as well.

I agree the futures API documentation isn't that great. It's also confusing since binance has the USDT-based futures (the original futures) and the COIN-M futures (which seem to be added later), leading to a poor API design in general.

ppamorim commented 3 years ago

Please do. I'm stuck. ☹️

dorak88783 commented 3 years ago

I have a first endpoint working (https://github.com/dorak88783/binance-rs/tree/add_futures_websockets) but I'll need a bit more time to organize everything into a nice API.

dorak88783 commented 3 years ago

Continued in https://github.com/wisespace-io/binance-rs/pull/124.