Closed ppamorim closed 3 years ago
Very very nice, impressive amount of work.
@dorak88783 I am fighting with the compiler, cargo build
in my machine does not compile the doctest
by some reason...
@dorak88783 I am fighting with the compiler,
cargo build
in my machine does not compile thedoctest
by some reason...
you should be able to see exactly what github is doing by looking at the config in .github/action
; if you run exactly the same on your machine then there's some other configuration option. Do you have the latest version of rust?
I never worked with doctest
myself.
@ppamorim I'm only not really sold on the change from ()
to the custom-made Void
. I thought Void
was a built-in but it's something custom. I don't have enough Rust experience to really judge this.
@ppamorim I'm only not really sold on the change from
()
to the custom-madeVoid
. I thoughtVoid
was a built-in but it's something custom. I don't have enough Rust experience to really judge this.
()
causes serde to crash.
@dorak88783 I am fighting with the compiler,
cargo build
in my machine does not compile thedoctest
by some reason...you should be able to see exactly what github is doing by looking at the config in
.github/action
; if you run exactly the same on your machine then there's some other configuration option. Do you have the latest version of rust?I never worked with
doctest
myself.
It's the same strangely or not. Anyway it's fixed.
@ppamorim Great work here.
@ppamorim Great work here.
Thank you very very much!
Would you like to rename Void
to something else? I am not sure how to name it properly.
@ppamorim Great work here.
Thank you very very much!
Would you like to rename
Void
to something else? I am not sure how to name it properly.
Is it just an empty struct? You may use a synonym (adjective) such as Emptied, Blank, Unfilled
@ppamorim I now see there's also a create called void
, maybe this also provides a more uniform/standard way to use this Void? I didn't check it myself yet. https://docs.rs/void/1.0.2/void
@wisespace-io @dorak88783 I think there is a way to map Void
(internally it will be called Empty
) to ()
which makes more sense and it won't break the code.
.map(|empty| ())
did the job.
In this PR:
stop_limit_sell_order
andtest_stop_limit_sell_order
. #hotfix