search

wisespace-io / bitfinex-rs

Bitfinex trading api
Other
57 stars 33 forks source link

Support Position Snapshot ('ps') channel data #6

Closed sebnow closed 5 years ago

sebnow commented 5 years ago

I'm not sure if this should be added as part of DataEvent. The structure is somewhat different for authenticated channel events. Looking at the NodeJS implementation, public channel events are handled in a special way, and the default is to handle authenticated channel data. This implementation's logic is a bit different.

https://docs.bitfinex.com/v2/reference#ws-auth-position

wisespace-io commented 5 years ago

I see, I looked at Golang implementation

https://github.com/bitfinexcom/bitfinex-api-go/blob/master/v2/websocket/channels.go#L94

They have handlePublicChannel and handlePrivateChannel. I think it is how we should do.

wisespace-io commented 5 years ago

Are you planing to implement it? Otherwise I can do it later.

sebnow commented 5 years ago

Sorry, I haven't been working on the project that requires this recently. I probably won't get to it any time soon.

Can close this for now I guess.