search

wisespace-io / yubico-rs

Yubikey client API library, Challenge-Response & Configuration
Other
52 stars 13 forks source link

Async #11

Closed pierre-l closed 5 years ago

pierre-l commented 5 years ago

Hi,

I'm in need of an asynchronous OTP check so here is a proposal to support futures.

I allowed myself to change the API by making the "Yubico.verify" method a simple function, let me know if there's any argument against that.

Also, I've noticed the examples are in an "example" directory instead of the usual "examples" name. Any specific reason for that?

Thanks in advance.

wisespace-io commented 5 years ago

@pierre-l Thank you for the contribution. The example folder was just a typo that nobody fixed. Could you move all the examples to the new examples folder? Would be also good to update the sync example as it will not work once you changed the api.

pierre-l commented 5 years ago

@wisespace-io Thanks, that's exactly the answer I was hoping for. Will do!

pierre-l commented 5 years ago

@wisespace-io Done