search

wisespace-io / yubico-rs

Yubikey client API library, Challenge-Response & Configuration
Other
52 stars 13 forks source link

Fix compile error from last PR #7

Closed dani-garcia closed 5 years ago

dani-garcia commented 5 years ago

Hello, the last PR seems to have some errors, these changes should fix them.

About the new dependency introduced, I checked the source for another one of the crypto libraries in use (crypto_mac) to see what would be appropiate: https://docs.rs/crypto-mac/0.7.0/src/crypto_mac/lib.rs.html#13

If you prefer an alternative, I can change it no problem.

PS: I keep a fork of this project with a feature to disable usb, similar to the existing online one. Would you be interested in another PR for that? The reason is I'm developing server software and I'd rather not introduce a dependency to libusb.

wisespace-io commented 5 years ago

@dani-garcia the online feature was introduced due a similar requirement, it would require to install/build openssl. Your PR is very welcome if we can handle both cases. See https://github.com/wisespace-io/yubico-rs/issues/5