search

wisetime-io / vscode-branch-in-window-title

Visual Studio Code extension that shows the current Git branch in the window title
Apache License 2.0
12 stars 6 forks source link

Made branch template configurable #17

Closed AnrDaemon closed 11 months ago

AnrDaemon commented 1 year ago

Added branchInWindowTitle.branchTemplate configuration setting.

vyshane commented 1 year ago

Hi, I can see 2 test failures:

1) branchDidChange should be called with undefined branch if the .git/HEAD file does contain a branch 2) branchDidChange should be called with the branch name if the .git/HEAD file contains a branch

AnrDaemon commented 1 year ago

I'm not familiar with VSCode extensions development. Can you help me please?

vyshane commented 1 year ago

I've fixed the failing tests in master. Can you please rebase?

To run the tests, run the following command in the project root directory:

npm run test
AnrDaemon commented 1 year ago

Will see about it at monday. Don't have Node runtime at home.

AnrDaemon commented 1 year ago

[main 2022-11-14T07:34:53.677Z] Error: Running extension tests from the command line is currently only supported if no other instance of Code is running. at Te.claimInstance (C:\Users\Admin\Documents\gh\branch-in-window-title.vscode-test\vscode-win32-archive-1.73.1\resources\app\out\vs\code\electron-main\main.js:84:8908) at process.processTicksAndRejections (node:internal/process/task_queues:96:5) at async C:\Users\Admin\Documents\gh\branch-in-window-title.vscode-test\vscode-win32-archive-1.73.1\resources\app\out\vs\code\electron-main\main.js:84:5144 at async Te.startup (C:\Users\Admin\Documents\gh\branch-in-window-title.vscode-test\vscode-win32-archive-1.73.1\resources\app\out\vs\code\electron-main\main.js:84:4984)

Tests are failing, but I don't understand why and unable to debug. :/ Will try to do some research once I get more time, if nobody give a hand sooner.

AnrDaemon commented 1 year ago

PR rebased on current master.

AnrDaemon commented 1 year ago

This should be more useful, although you would have to restart the IDE to apply configuration changes.

AnrDaemon commented 1 year ago

Ping? Also, I'd like to request a rollback to a lower version of VS Code. 1.70 to be available on last Win7 release.

AnrDaemon commented 11 months ago

Thanks! Eagerly awaiting new release.

vyshane commented 11 months ago

@AnrDaemon I have just published a new build to the VS Code Marketplace. You can grab it here: https://marketplace.visualstudio.com/items?itemName=wisetime.branch-in-window-title

Thank you for your contribution!