wish-wg / webrtc-http-ingest-protocol

WHIP - WebRTC HTTP ingest protocol draft
50 stars 10 forks source link

Remove wrong attributes from sdp on bundle-only lines #185

Closed murillo128 closed 9 months ago

murillo128 commented 9 months ago

Q1: Section 5.2.1 of RFC 8829 (JSEP) says:

"Bundle-only "m=" sections MUST NOT contain any ICE credentials and MUST NOT gather any candidates."

However, in the SDP example in Section 4 of WHIP the bundle-only m- section contains ICE credentials (ufrag and pwd).

SUGGESTION: Remove the ICE credentials from the bundle-only m- sections.

Q2: Section 5.2.1 of RFC 8829 (JSEP) says:

"[RFC8859] groups SDP attributes into different categories. To avoid unnecessary duplication when bundling, attributes of category IDENTICAL or TRANSPORT MUST NOT be repeated in bundled "m=" sections, repeating the guidance from [RFC8843], Section 7.1.3. This includes "m=" sections for which bundling has been negotiated and is still desired, as well as "m=" sections marked as bundle-only."

However, in the SDP example in Section 4 of WHIP the bundle-only m- section contains the following IDENTICAL/TRANSPORT category attributes:

fingerprint (TRANSPORT) setup (TRANSPORT) rtcp-mux (IDENTICAL) rtcp-mux-only (IDENTICAL) rtcp (TRANSPORT)

murillo128 commented 9 months ago

182