wish / katalog-sync

A reliable node-local mechanism for syncing k8s pods to consul services
MIT License
36 stars 7 forks source link

Check actual health of service on deregister call #46

Closed jacksontj closed 3 years ago

jacksontj commented 3 years ago

Previously we would only allow the sidecar to be marked as deregistered once the service was missing in consul. Unfortunately this meant that sidecar services basically had to wait indefinitely; as the service would exist in consul until it was removed in k8s -- which was waiting on the sidecar. In this patch we start checking the service's health in consul; if its not passing we consider it de-registered.