wishhhmaster / CoinTNet

CoinT.Net - a C# trading tool for cryptocurrencies
42 stars 26 forks source link

Inaccurate fee calculations on Cryptsy #6

Open thewarlok666 opened 10 years ago

thewarlok666 commented 10 years ago

It would appear that there is a problem calculating fees and totals. Also, besides dropping trailing zeros, Only 6 digit decimals being displayed. could this lead to inadvertent rounding (GREEN)? Version 0.0.0.5a-r1

05-22-2014-01 incorrect calculations

05-22-2014-02 incorrect calculations

wishhhmaster commented 10 years ago

Yes, there are 2 problems here:

Cryptsy provides an API method for calculating fees for a trade, but no method to retrieve the actual fee parcentage... so it means we have to call they API for every calculation (or make one calculation and work out the fee from there)

Edit: the API for calculating fees does not take a currency pair as input parameter, so it always returns 0.2%/0.3% for buy/sell orders. Only a few pairs seem to have a 0.25% fee; USD pairs, LTC/BTC, FTC/BTC, and I'm not sure which other ones...