wishkit / wishkit-ios

In-App Feature Requests. Made Easy.
https://wishkit.io
MIT License
137 stars 24 forks source link

macOS Modal Buttons #38

Closed OskarGroth closed 8 months ago

OskarGroth commented 10 months ago

The modal on macOS only has a single action button, or none at all:

Screenshot 2024-01-16 at 16 25 16 Screenshot 2024-01-16 at 16 27 07

So the only way to dismiss the sheet is to press Esc, which can be quite unintuitive.

Furthermore, the custom button design is hard to read with the default theme (and does not fit with macOS design):

Screenshot 2024-01-16 at 16 29 09

I suggest:

martinlasek commented 8 months ago

Closing the issue with the introduction of an x-button for closing the modal in v4.0.0.

As for the "save" button the detail view (including the button) is currently shared across all platforms (iOS, macOS, visionOS, iPad OS). But I can see to implement a separate button for macOS only.

Thanks!