search

wishtack / wishtack-steroids

Frontend on Steroids: Reactive Component Loader, RxJS Scavenger...
https://wishtack.io
MIT License
96 stars 16 forks source link

chore(upgrade): Fix scavenger to work in Angular8+ #186

Closed timwright35 closed 5 years ago

timwright35 commented 5 years ago

The imports for core-js seemed to have changed when updating to the new packages for Angular 8, this fixes that but likely makes it so you can not use scavenger in Angular lower than version 8. There might be a better solution but this works for Angular 8+ people for now.

yjaaidi commented 5 years ago

Hi @timwright35! Thank you for your feedback but I am not sure that core-js changed the paths recently. Could you please reproduce the issue on Stackblitz? Thank you in advance.

timwright35 commented 5 years ago

Hi @timwright35! Thank you for your feedback but I am not sure that core-js changed the paths recently. Could you please reproduce the issue on Stackblitz? Thank you in advance.

I do not think core did change the paths. The issue I think stems from Angular and changes to shims etc. I might be wrong but when I researched it after I was getting the errors this was the solution.

yjaaidi commented 5 years ago

This issue was fixed in latest release @wishtack/rx-scavenger@2.0.0