wishtack / wishtack-steroids

Frontend on Steroids: Reactive Component Loader, RxJS Scavenger...
https://wishtack.io
MIT License
96 stars 16 forks source link

unable to work with after angular 9 migration #197

Closed quentinbt closed 4 years ago

quentinbt commented 4 years ago

Hi,

Since We migrate from angular 8.x to 9 our application is not working properly with our subscriber, I feel like scavenger do not auto unsubscribe anymore

ex:

this.queryService
          .getQueryParams()
          .pipe(this._scavenger.collectByKey("queryParams"))
          .subscribe(params => {
            this.getMultiSearches(currentUser.organizationId, params);
          });
quentinbt commented 4 years ago

ok, I was on 1.0.5 so I bump to 2.0.1 and now when I run ng serve I get the following error:

ERROR in ./node_modules/@wishtack/rx-scavenger/dist/scavenger.js
Module not found: Error: Can't resolve 'core-js/es/map' in '/Users/quentinbasset/workspace/marketparts-front/node_modules/@wishtack/rx-scavenger/dist'
ERROR in ./node_modules/@wishtack/rx-scavenger/dist/scavenger.js
Module not found: Error: Can't resolve 'core-js/modules/es.array.includes' in '/Users/quentinbasset/workspace/marketparts-front/node_modules/@wishtack/rx-scavenger/dist'
quentinbt commented 4 years ago

ok, I bumped from "core-js": "^2.6.11" >> "core-js": "^3.6.4" and it works

yjaaidi commented 4 years ago

Hi @quentinbt! Thank you for the feedback and sharing the solution 😉