search

wisk / medusa

An open source interactive disassembler
Other
1.04k stars 92 forks source link

reserved identifier violation #10

Closed elfring closed 10 years ago

elfring commented 10 years ago

I would like to point out that identifiers like "_MEDUSA_ADDRESS_" and "__MEDUSA_VIEW_HPP__" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

wisk commented 10 years ago

Hi @elfring,

You're definitely right, at the beginning of this project, we used MEDUSA_, but now I think it's better to use the following convention: _MEDUSAHPP. I'll to try to normalize these headers soon.

Thanks for reporting.

elfring commented 10 years ago

Would you like to reconsider the consequences of underscores in such identifiers once more?

wisk commented 10 years ago

Ok, I agree with you, I'll update header guard convention asap.

Thanks for pointing this out. :)

wisk commented 10 years ago

This patch https://github.com/wisk/medusa/commit/f15232d10825842c74b3f9de59e2a95aadde8540 normalizes header guard naming convention. Fell free to re-open this ticket if I missed one of them. :)

elfring commented 10 years ago

Thanks for your source code improvement.