search

wisk / medusa

An open source interactive disassembler
Other
1.04k stars 92 forks source link

Simplify formatting of multiplications when one of the operands is 1. #44

Closed ekse closed 8 years ago

ekse commented 8 years ago

There are some cases where a register is multiplied by 1 :

# disassembly of "\xC7\x04\x24\x18\x00\x00\x00"
mov              dword [esp * 0x0001], 0x0018

This commit simplifies the output to this : 0804847e mov dword [esp], 0x0018

wisk commented 8 years ago

Hi ekse,

Even if it's useless, I like to see the "* 1" since it remembers me that the operand encoding uses SIB. But I think you're right and the simplified form is better.

Thanks! :)