search

wisk / medusa

An open source interactive disassembler
Other
1.04k stars 92 forks source link

Bug in ogdf #5

Closed ivan-kulikov-dev closed 10 years ago

ivan-kulikov-dev commented 10 years ago

qMedusa: /home/ivan/projects/medisa_project/ogdf/include/ogdf/basic/NodeArray.h:145: T& ogdf::NodeArray::operator [with T = double; ogdf::node = ogdf::NodeElement*]: An assertion «v != 0 && v->graphOf() == m_pGraph» missed. Аварийный останов (сделан дамп памяти)

1)open any file 2)click To log window 3)press Ctrl+F

CFG view fall too...((

wisk commented 10 years ago

Hi @gunmetal313, and thanks for reporting this issue.

Unfortunately, I'm unable to reproduce the bug (tested on Windows/Debug version). Could you provide more info about your configuration? (arch, os, build_type, branch, ...)

ivan-kulikov-dev commented 10 years ago

ohhh.Ctrl+F is CFG view.On master branch all ok.It where some falls CFG view on dev branch.But all ok on current commit https://github.com/wisk/medusa/commit/6df15e7d6fdd6ad8c529f00420d30b087f58679b :)

wisk commented 10 years ago

I suspect the assert is triggered when there's nothing to display (i.e. no block). This line https://github.com/wisk/medusa/blob/dev/src/ui/qt/ControlFlowGraphScene.cpp#L30 should fix the problem since Medusa::BuildControlFlowGraph (https://github.com/wisk/medusa/blob/dev/src/core/analyzer.cpp#L934) should return false if the CFG is empty. I close this issue for now, but if you're still able to trigger this assert, feel free to notify me, I'll re-open it.