search

wisk / medusa

An open source interactive disassembler
Other
1.04k stars 92 forks source link

Boost version requirement is not present/incorrect. #8

Closed oldtopman closed 10 years ago

oldtopman commented 10 years ago

I attempted to compile medusa on Slackware 14.0x64. After updating cmake and installing ogdf, the cmake completed successfully, but the make would crash with the following error.

ash-4.2$ make -j2
Scanning dependencies of target Medusa
[  1%] [  1%] Building CXX object src/core/CMakeFiles/Medusa.dir/analyzer.cpp.o
Building CXX object src/core/CMakeFiles/Medusa.dir/address.cpp.o
[  2%] Building CXX object src/core/CMakeFiles/Medusa.dir/architecture.cpp.o
[  3%] Building CXX object src/core/CMakeFiles/Medusa.dir/array.cpp.o
[  4%] Building CXX object src/core/CMakeFiles/Medusa.dir/basic_block.cpp.o
[  5%] Building CXX object src/core/CMakeFiles/Medusa.dir/cell.cpp.o
[  6%] Building CXX object src/core/CMakeFiles/Medusa.dir/cell_action.cpp.o
[  7%] Building CXX object src/core/CMakeFiles/Medusa.dir/cell_data.cpp.o
[  8%] Building CXX object src/core/CMakeFiles/Medusa.dir/cell_text.cpp.o
[  9%] Building CXX object src/core/CMakeFiles/Medusa.dir/character.cpp.o
[ 10%] Building CXX object src/core/CMakeFiles/Medusa.dir/configuration.cpp.o
In file included from /home/oldtopman/applications/medusa/inc/medusa/cell_action.hpp:16:0,
                 from /home/oldtopman/applications/medusa/src/core/cell_action.cpp:1:
/home/oldtopman/applications/medusa/inc/medusa/medusa.hpp:88:98: error: default argument for parameter of type ‘medusa::Architecture::SharedPtr {aka boost::shared_ptr<medusa::Architecture>}’ has type ‘std::nullptr_t’
[ 11%] Building CXX object src/core/CMakeFiles/Medusa.dir/control_flow_graph.cpp.o
make[2]: *** [src/core/CMakeFiles/Medusa.dir/cell_action.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/core/CMakeFiles/Medusa.dir/all] Error 2
make: *** [all] Error 2

Updating to Boost 1.56 resolved the problem, so I propose a version check, or at least a modified one. EDIT: I was on Boost 1.49 before.

wisk commented 10 years ago

This patch https://github.com/wisk/medusa/commit/ad4829d8f5eb3d4bcf8a5d1a17b0c07609d3c186#diff-af3b638bc2a3e6c650974192a53c7291R46 should fix this issue. I also updated the documentation. Please, tell me if it's ok for you.

Thanks for reporting.