Complete quoting for parameters of some CMake commands

wisk / medusa

An open source interactive disassembler

Other

1.04k stars 92 forks source link

Complete quoting for parameters of some CMake commands #9

Open elfring opened 10 years ago

elfring commented 10 years ago

Some parameters (like "${DOCROOT}/Doxyfile" and "${INCROOT}/address.hpp") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

wisk commented 10 years ago

Hi @elfring and thanks for the advice.

It'd help me a lot if you could provide me an example of path which trigger this issue.

elfring commented 10 years ago

Would you like to look at any applied changes (or bug reports) for other software?

wisk commented 10 years ago

Thanks for the link, I'll fix this ASAP.