search

wisniewskit / google-search-fixer

99 stars 36 forks source link

Replace "Access your data for all websites" permission with google TLD permissions #17

Open Rob--W opened 3 years ago

Rob--W commented 3 years ago

The extension currently requests the "Access your data for all websites" permission. While the initial implementation required that, the latest version (from #11) does not. We should check if Firefox for Android (Fenix) is able to cope with almost 200 domains in the permission lists (and if reducing the permission does not trigger new warnings, and that we don't need other host permissions). If it works, we can replace

https://github.com/wisniewskit/google-search-fixer/blob/108b2781d5f339e6d2b4a242745e48b149db589c/manifest.json#L23

with the list of host permissions at

https://github.com/wisniewskit/google-search-fixer/blob/108b2781d5f339e6d2b4a242745e48b149db589c/manifest.json#L39-L235

yaakovfeldman commented 2 years ago

There is one other Google website that I suggest be added. Google search cached results are visible under the googleusercontent.com domain. This no longer works properly for Firefox android users.

I came across this issue through the web archives extension bug report https://github.com/dessant/web-archives/issues/33

I was unable to access Google cached pages. I've had to install an additional user agent switcher just for googleusercontent.com which fixes this issue.

Would you consider adding that domain to the list and spoofing user agent also for this domain?

ncaq commented 2 years ago

I write to my Google addon.

https://github.com/ncaq/google-search-title-qualified/blob/935dd4ee50f6507ebb44a16eac752be7171e8070/manifest.json.make.ts#L5

Your can copy from.