search

wisp-forest / accessories

A extendable and data-driven Accessory Mod for Minecraft
Other
25 stars 8 forks source link

[Forge 1.20.1] Curios Attribute Modifiers not applying for non Curio implementing Items #100

Closed MFRarDer closed 3 days ago

MFRarDer commented 1 week ago

In original Curios Mod,I can use the command(For example:/give @p minecraft:apple{CurioAttributeModifiers:[{Slot:"ring", AttributeName:"generic.attack_damage", Name:"generic.attack_damage", Amount:20.0, Operation:0}]}).And The apple is not Curios originally.But I can make it to Ring driven by datapack. But I use Accessories and Curios Compat Layer for Accessories ,this way is not work in this condition.If the item is driven by datapack,it is not work.And the item is create by other mod maker(For example:irons_spellbooks)I can use the command to adjust the attribute.(/give @p irons_spellbooks:mana_ring{CurioAttributeModifiers:[{Slot:"ring", AttributeName:"generic.attack_damage", Name:"generic.attack_damage", Amount:20.0, Operation:0}]}) image（I made item by KubeJS） image(It is not work!) image(It made by Iron's Spellbook) image(It is work) Above Question,When I unloaded Accessories and Curios Compat Layer for Accessories and loaded Curios API,This Nbt will work. image(Use Curios Api ,it is work)

Dragon-Seeker commented 1 week ago

Ok so a bit confused about what the problem is here but I can assume that you are saying that the given attributes are not being found for the given item that is equipable within a given slot. I believe such comes down to the item not having a Curio within Curios API and I have a method to load the data-driven is being called for only curio item which is a oversight on my part

Dragon-Seeker commented 1 week ago

Rework is for 1.21 fixing this issue but unknown if such will get backported to 1.20.1 as I have had very little time to keep backporting every fix to the previous version.

MFRarDer commented 6 days ago

Thank You.If you still have the time, please optimize for version 1.20.1, as most mods are still on 1.20.1.

Dragon-Seeker commented 3 days ago

Pushed a fix for 1.21 and for the foreseeable future I will only be updating such as I currently have limited time to backport bug fixes for 1.20.1 that are not critical issues. It may change coming up but as of now such is reality.