wisp-forest / alloy-forgery

Alloy smelter mod for Fabric
MIT License
43 stars 18 forks source link

[Feature Request] Support KubeJS #106

Closed EvanHsieh0415 closed 1 year ago

EvanHsieh0415 commented 1 year ago

like

ServerEvents.recipes(event => {
    event.recipes.alloyForgery.forging(
        { // Output
            priority: Array, // if ${default} isn't tag: Optional, default: [${default}]
            default: String,
            count: Number // Optional, default: 1
        },
        [ // Input[]
            Item / Ingredient,
            ...
        ]
    ).overrides(Object) // Optional, default: {}
    .minForgeTier(Number) // Optional, default: 1
    .fuelPerTick(Number) // Optional, default: 5
})
Dragon-Seeker commented 1 year ago

I really don't understand the need here. Dosn't KubeJS allow for JSON Injection for custom recipes? Why add support for something that will be required to maintain compatibility and a feature used as a Fancyer wrapper than custom?

More info on what your requesting and the reason for such would allow for better evaluation of this.

EvanHsieh0415 commented 1 year ago

First of all, I apologize for my previous use of "require". I'm not very familiar with English, which caused me to use the wrong vocabulary.

Furthermore, this mod is suitable for modifying recipes in modpacks, and if it supports KubeJS, it can improve development efficiency. However, if modpack developers use event.custom built into KubeJS, it will make the code redundant and difficult to maintain.

EvanHsieh0415 commented 1 year ago

By the way, I have now written a recipe builder using JavaScript.

image

gliscowo commented 1 year ago

Given that Alloy Forgery recipes are already perfectly usable using just standard KubeJS features, we won't be implementing and thus maintaining any specific support.

Cheers

EvanHsieh0415 commented 1 year ago

Although I do not think it is perfectly, but since the author does not intend to produce, but so be it