wisp-forest / alloy-forgery

Alloy smelter mod for Fabric
MIT License
43 stars 18 forks source link

Attempting to restore EMI compat in 1.20 #111

Closed NattoRiisa closed 1 year ago

NattoRiisa commented 1 year ago

reverts disabling EMI on #108 In case there's some issues with the pull, please remind me so I can close it as invalid.

Noaaan commented 1 year ago

Hey, some couple of notes with this PR

Because of these issues, per your request, I will go ahead and close this and restore the compatability at a later date

NattoRiisa commented 1 year ago

Hey, some couple of notes with this PR

  • It includes a build.gradle file in the compat folder, which is definitely not necessary
  • EMI has had larger API changes for 1.20, as of EMI 1.0.0+ where it became a multiloader project. There is also no version bump here, so there are very likely breaking changes with it that is not reflected in this PR
  • Some of the code is still left commented out, which seems like a mistake

Because of these issues, per your request, I will go ahead and close this and restore the compatability at a later date

alright, thank you! sorry for the unnecessary PR!