search

wisp-forest / conjuring

A mod about spawners, tools and (secretly) food
https://modrinth.com/mod/conjuring
MIT License
9 stars 11 forks source link

soulfire_forge model texture error #30

Closed Skelun closed 2 years ago

Skelun commented 2 years ago

The _soulfireforge model is having a visual glitch due to the face's texture vertical height being set to 0. It should be 1.

https://github.com/gliscowo/conjuring/blob/79a0281c8a1a50003c4577779deb6225171ea1bd/src/main/resources/assets/conjuring/models/block/soulfire_forge_on.json#L160-L163

https://github.com/gliscowo/conjuring/blob/79a0281c8a1a50003c4577779deb6225171ea1bd/src/main/resources/assets/conjuring/models/block/soulfire_forge_off.json#L141-L144

The top most block image

Here's the code fixed and the preview.

    "north": {"uv": [12, 0, 4, 1], "texture": "#0"},
    "east": {"uv": [11, 0, 5, 1], "texture": "#0"},
    "south": {"uv": [12, 0, 4, 1], "texture": "#0"},
    "west": {"uv": [11, 0, 5, 1], "texture": "#0"},

Fixed image