wisp-forest / gadget

Debugger's Delight
https://modrinth.com/mod/gadget
GNU Lesser General Public License v3.0
44 stars 6 forks source link

Use fake packet for SynchronizeRecipesS2CPacket #18

Closed BasiqueEvangelist closed 1 year ago

BasiqueEvangelist commented 1 year ago

The vanilla representation of the packet doesn't write the lengths of the individual recipes. This is fine when you need to know all recipe serializers anyway, but can mean that the entire sync packet becomes a read error if one of the mods isn't installed on the packet dump reader's client. It would most likely be much better if SynchronizeRecipesS2CPacket was replaced with a fake gadget-specific packet that does have lengths, so that if one recipe fails to deserialize, the entire packet won't fail.