wisp-forest / numismatic-overhaul

Terraria-style currency in Minecraft
https://modrinth.com/mod/numismatic-overhaul
MIT License
27 stars 20 forks source link

Difficulty trading with villagers (phantom coins) #142

Open emeryplyler opened 6 months ago

emeryplyler commented 6 months ago

For some trades, when I click the trade, it will move less than the required amount of coins into the coin slot. If I click the trade again or press space bar, it will appear to fill in the full amount. For example, a bell costs 30 silver. I click it once and 24 silver is put in the coin slot. I click a second time and 36 silver are now in the coin slot. However, if I click the 30 silver to pick it up, I end up holding only 24 silver. If I click the bell, everything goes normally. If I want to buy another bell, I will need to click twice again or press space bar twice.

If I have Mouse Wheelie installed, the problems are much worse, but Mouse Wheelie also enables the player to trade instantly which seems to mostly avoid these issues. Maybe the problems come from the shift + click +drag mechanic that it adds for moving multiple items in one mouse press? I want to trade 1 silver for some arrows. When I either have silver coins in my inventory or in my purse and then click the trade, the coin slot is filled with what seems to be a random amount of "phantom" copper coins (they disappear if clicked) and I cannot complete the trade. If I click a second time, the phantom coins go into my hotbar and a silver coin is pulled from my purse and into the coin slot of the trade. I can then complete the trade, but the copper coins may stay. Because of this, I'm able to fill up my inventory with phantom copper coins which disappear when interacted with.

Despite all this, I don't think I've ever lost any coins due to these bugs. The amount of money I have afterwards always seems to be consistent with what I would actually have spent if there were no bugs.