wisp-forest / numismatic-overhaul

Terraria-style currency in Minecraft
https://modrinth.com/mod/numismatic-overhaul
MIT License
26 stars 20 forks source link

Cartographer map for 5 silver locks up the game #147

Open Official-V-Zer0 opened 2 months ago

Official-V-Zer0 commented 2 months ago

So I've had an issue with the cartographer villager when he's spawned in (egg or natural) with a trade of 5 silver for a map. It gives him full (or maybe over full) bar and makes everything freeze up, quitting save loops the world needing to be task managered, and when going back on it has rolled back a few actions. So far in my test it's only them. Not even shepherd with a similar trade (5 silver for shears) only gives half bar

here's the log https://mclo.gs/tLVlrNQ

Noaaan commented 2 months ago

Are you sure this isn't a duplicate of https://github.com/wisp-forest/numismatic-overhaul/issues/93 ?

Official-V-Zer0 commented 2 months ago

It seems it can be. But then the only fix is to edit the mod itself. So the solution would be to make a compat mod or add Yung's structures in a mod update.

Official-V-Zer0 commented 2 months ago

Ok so the fix for #93 worked but the map wasn't even one that lead to the monument, just an empty map

But the map that came with apprentice level was the one causing the issue trying to generate